-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autograph should make it possible to look-up available keyids for a signer #737
Comments
Per the signing meeting discussion earlier this week, Hal and I didn't think there would be any issues with exposing the keyids the current user already has access to. Autograph edge pins a keyid, so we initially thought it would not support the new endpoint. However, it might be handy to have edge proxy an API token authed request to the same endpoint. mozilla-services/autograph-edge#9 is a similar issue. The autograph API is already unprefixed and over JSON. I think it's OK to stick with that. A few implementation options come to mind: A) Add an authed
[
"key-signer-id-1",
"key-signer-id-2",
...
] We can probably avoid worrying about pagination or filtering, since the responses are small and signers usually have access to a handful of key ids. Optionally, the monitor ID could return all signers we're monitoring. B) Alternatively, a C) return keyids in a HEAD response to /sign/{data,file,hash} URLs possibly in a header like D) return allowed keyids in 403 responses to sign requests. Relatively simple, but complicates the signing handlers and sorta weird to require an invalid request to get data back. We could also include more data in the responses e.g. including a object with the signer config and options. |
Our use case is largely for humans, I believe - I don't think we were planning to implement anything in D feels weird to me. All of the other options seem roughly equivalent. |
As I understand it, keyids are not secrets. As an autograph user, it would be useful to be able to look up which ones are available for a particular signer, and perhaps be able to look up available signers as well. @escapewindow had a couple of ideas, including:
/signers
to get signers and/or/signers/foo
to get keyids for thefoo
signer)Feel free to close this as undesirable if we the current obfuscation is wanted :)
The text was updated successfully, but these errors were encountered: