Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to update lists due to timestamp #156

Open
4 tasks
say-yawn opened this issue Sep 14, 2020 · 0 comments
Open
4 tasks

Failure to update lists due to timestamp #156

say-yawn opened this issue Sep 14, 2020 · 0 comments

Comments

@say-yawn
Copy link
Contributor

say-yawn commented Sep 14, 2020

About this Issue

Surfaced from bug 1662895, we noted that a Firefox user who updated to the latest release was experiencing breakages due to their entity list not being updated. The cause was that the Shavar uses timestamp to decide whether an update should happen which means if versioned lists were updated during the same shavar-list-creation script run, the timestamp of the file will be the same resulting in Shavar responding with DO NOT UPDATE even though the content of the file is different.

Acceptance Criteria

  • When checking for update needed using /downloads we should check checksum of the file
  • Checksum of the file should be everything minus the header
  • If the checksum is different, /downloads should respond with the download link for the latest versioned list
  • If the checksum is same (regardless of what the version of the list is/was) NO update should happen.
@say-yawn say-yawn changed the title Check checksum and timestamp Failure to update lists due to timestamp Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant