This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Create React App does not lint TypeScript #152
Comments
Is this because we're using ESLint instead of TSLint? |
Scratch that - this is an ESLint error. |
I'm digging into it right now. So far, adding typescript to CRA seems to kill the linting features so I'm trying to figure out why. |
kumar303
changed the title
Lint reporting is broken
The default Create React App linting is broken
Feb 6, 2019
Ah, ok, linting was never supported for TypeScript. I illustrated the problem here: facebook/create-react-app#5641 (comment) |
kumar303
changed the title
The default Create React App linting is broken
Create React App does not lint TypeScript
Feb 6, 2019
This will be fixed by #633 |
Fixed. |
Could you also add a qa:not needed label to this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
For some reason, linting is broken. I cannot get
yarn react-scripts-start
to show lint output.Here's an example of how it should work. I followed these steps:
npx create-react-app lint
cd lint
yarn start
const unsuedVar = 2
to the top ofrender()
inApp.js
Now I see this in the console:
If I try to trigger the same lint error in
addons-code-manager
, I do not see the lint error. Instead I seeCompiled successfully
.The text was updated successfully, but these errors were encountered: