Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ReportAbuseButton to setUIState #2060

Open
kumar303 opened this issue Sep 24, 2018 · 5 comments
Open

Convert ReportAbuseButton to setUIState #2060

kumar303 opened this issue Sep 24, 2018 · 5 comments
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@kumar303
Copy link
Contributor

kumar303 commented Sep 24, 2018

For QA: ensure the Report abuse button on the add-on detail page still works without regressions.

The ReportAbuseButton relies on custom actions to set internal state. These actions should be removed and replaced with setUIState.

In #2059, we will potentially have two Report abuse buttons on the same page. To support that we would need to enhance the current actions/reducers or just switch to setUIState() and set the component ID appropriately. Let's do the latter.

┆Issue is synchronized with this Jira Task

@kumar303
Copy link
Contributor Author

Some complimentary clean-up will happen in #12655

@grlwholifts
Copy link

hello @kumar303 , I'd like to take this up. Is this issue still available?

@kumar303
Copy link
Contributor Author

Hi @ruchikabgosain, thanks for your interest. This isn't a good issue to work on because abuse reporting might move away from https://addons.mozilla.org/ and into Firefox itself (see https://bugzilla.mozilla.org/show_bug.cgi?id=1540175). However, we aren't sure yet. I suggest looking at contrib: welcome patches as those are mostly ready to go.

@grlwholifts
Copy link

Okay @kumar303! Will do that 🙇

@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 3, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 3, 2024
@diox diox removed triaged labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

No branches or pull requests

8 participants