Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

'status' key in JSON response #149

Open
ashleygwilliams opened this issue Aug 6, 2015 · 4 comments
Open

'status' key in JSON response #149

ashleygwilliams opened this issue Aug 6, 2015 · 4 comments

Comments

@ashleygwilliams
Copy link
Contributor

would like more info on what the motivation was for adding a status attribute to the JSON response! it adds complication to building clients on top of the API. it also strikes me as redundant as HTTP should be enough information? potentially i am missing something. thanks.

@cadecairos
Copy link
Contributor

It doesn't need to be there. we could provide a v2.0 handler function that doesn't provide it.

hapi-version is already included in the server for us to make use of

@simonwex
Copy link

simonwex commented Aug 6, 2015

Do we have a way of tracking wants for non-backwards-compatible changes in the API? We can force an update of the app, though it isn't a pretty user experience. If there are enough things that pile up, it may be worth doing at some point. -- especially while we have few users.

@cadecairos
Copy link
Contributor

I just added a "breaking change" label we can use to track, well, breaking changes.

@ashleygwilliams
Copy link
Contributor Author

error from ember:

WARNING: Encountered "status" in payload, but no model was found for model name "status" (resolved model name using webmaker-moderator@serializer:application:.modelNameFromPayloadKey("status"))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants