Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace version compare with NIH lib #21

Open
jsocol opened this issue Jun 11, 2012 · 2 comments
Open

Replace version compare with NIH lib #21

jsocol opened this issue Jun 11, 2012 · 2 comments

Comments

@jsocol
Copy link

jsocol commented Jun 11, 2012

Would semanticversion work for our version comparison needs? Then we could stop maintaining the version comparison module here. Firefox versions may be too idiosyncratic, though.

cc @lauraxt, because I know socorro is one of the biggest consumers of the version compare library.

@fwenzel
Copy link
Member

fwenzel commented Jun 11, 2012

Input is another consumer of this library.

Generally, I have no objections to using a library that already exists and might be maintained better than this, for sure.

Does it pass these tests: https://github.com/fwenzel/django-mozilla-product-details/blob/master/product_details/version_compare/tests.py ?

Also, not sure if anyone uses the numeric representation of versions in order to push version ordering into the database; Socorro might.

@jsocol
Copy link
Author

jsocol commented Jun 28, 2012

@lauraxt, anyone on your team have an opinion about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants