You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mozillians was missing languages.json in production. This is an error that should not go down quietly.
Download errors already keep the timestamp from being updated (ergo the next time the update script runs it will try again).
Perhaps a download error should always raise an exception? Will that be compatible with the intent of -q? Perhaps we need -q2 which will be quiet even if errors occur, and -q would just be quiet under normal circumstances.
Input appreciated.
The text was updated successfully, but these errors were encountered:
Is there a use case for this, e.g. where it's OK for a random download to fail and everything else should just work? What if it wasn't languages.json but something like firefox_versions.json that didn't download.
I am fine with making it atomic (or, well, close to it). Removing the target directory and creating a new temporary one, then moving it will probably not work because the target dir might have rights we can't reproduce. But if you want, download all files into a temporary dir, make sure it all worked, and only then move all the files into the target dir, rather than updating all that worked and ignoring the ones that didn't.
Sounds like a reasonable way of dealing with this.
mozillians was missing languages.json in production. This is an error that should not go down quietly.
Download errors already keep the timestamp from being updated (ergo the next time the update script runs it will try again).
Perhaps a download error should always raise an exception? Will that be compatible with the intent of
-q
? Perhaps we need-q2
which will be quiet even if errors occur, and-q
would just be quiet under normal circumstances.Input appreciated.
The text was updated successfully, but these errors were encountered: