Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way the script can quietly not download languages.json? #24

Open
fwenzel opened this issue Jun 21, 2012 · 2 comments
Open

Any way the script can quietly not download languages.json? #24

fwenzel opened this issue Jun 21, 2012 · 2 comments

Comments

@fwenzel
Copy link
Member

fwenzel commented Jun 21, 2012

mozillians was missing languages.json in production. This is an error that should not go down quietly.

Download errors already keep the timestamp from being updated (ergo the next time the update script runs it will try again).

Perhaps a download error should always raise an exception? Will that be compatible with the intent of -q? Perhaps we need -q2 which will be quiet even if errors occur, and -q would just be quiet under normal circumstances.

Input appreciated.

@jsocol
Copy link

jsocol commented Jun 28, 2012

Is there a use case for this, e.g. where it's OK for a random download to fail and everything else should just work? What if it wasn't languages.json but something like firefox_versions.json that didn't download.

@fwenzel
Copy link
Member Author

fwenzel commented Jun 28, 2012

I am fine with making it atomic (or, well, close to it). Removing the target directory and creating a new temporary one, then moving it will probably not work because the target dir might have rights we can't reproduce. But if you want, download all files into a temporary dir, make sure it all worked, and only then move all the files into the target dir, rather than updating all that worked and ignoring the ones that didn't.

Sounds like a reasonable way of dealing with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants