lint-staged doesn't recognize Node 10 as >= 6

[jankeromnes]

$ git commit -m "Awesome feature."
husky > npm run -s precommit (node v10.0.0)
lint-staged requires at least version 6 of Node, please upgrade
husky > pre-commit hook failed (add --no-verify to bypass)

Workaround is to add --no-verify after git commit.

[armenzg]

Is there an upstream issue?

[jankeromnes]

I don't know, I'm not sure where to find the code responsible for checking the Node version among husky, lint-staged, etc.

[armenzg]

I landed this fix on another repo:
mozilla-frontend-infra/firefox-health-dashboard@b56bacd

[jankeromnes]

Great news, thanks! 😁

[jankeromnes]

@armenzg Why not upgrade to lint-staged 7.2.0 instead of 7.0.5? Also, could we enable greenkeeper.io on this repository? Is the test coverage sufficient to catch any potential dependency-related regressions?

[armenzg]

I have no objections for that version.
I've enabled greenkeeper.io (I hope).
I don't know if it is enough. Any suggestions on how to determine that?

[jankeromnes]

I have no objections for that version.

Cool!

I've enabled greenkeeper.io (I hope).
I don't know if it is enough. Any suggestions on how to determine that?

You can find this repository in the greenkeeper.io website, and it should say that it is enabled.

Then some time soon, you should see its first pull request to this repo (I think it adds some things to package.json and other places like README.md, but you don't have to accept all of its initial suggestions. I only use it to keep my dependencies up-to-date, and since any pull request runs the tests, I easily know if an update will break my app or not.)

[jankeromnes]

So, @Standard8 helped me look into why Greenkeeper.io wasn't doing anything, and I decided that maybe we could try renovatebot.com, which seems to have more features and controls.

So we disabled Greenkeeper, and I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1477999 in order to enable Renovate. I'm looking forward to seeing what it can do for us.