Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Black Python formatter/linter? #160

Closed
pdehaan opened this issue Apr 14, 2020 · 4 comments
Closed

Add Black Python formatter/linter? #160

pdehaan opened this issue Apr 14, 2020 · 4 comments

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Apr 14, 2020

https://black.readthedocs.io/en/stable/installation_and_usage.html#usage

black . --exclude venv

Not sure how much linting for errors or issues Black does, or if it's mostly just a formatter (ESLint vs Prettier), so maybe we need to add other Python linting as well.

@groovecoder
Copy link
Member

Do we use black in other python code-bases? I've always used flake8 for python code.

@pdehaan
Copy link
Contributor Author

pdehaan commented Apr 14, 2020

I've heard that we use it, but I'll ping my larger team and see if they can point me to any prior works of art.

I did find https://bugzilla.mozilla.org/show_bug.cgi?id=1555560 in my email records, but that doesn't look merged yet.

@jeroenev
Copy link

Do we use black in other python code-bases? I've always used flake8 for python code.

Black is mostly a Code formatter, making sure all code is formatted consistently across a project, kinda like Prettier for JS.
So it's for a different purpose than Flake8.

@groovecoder
Copy link
Member

Closing this Black-specific issue for the more open-ended #162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants