From d547799747ec35b026e7db5d022b1edc6d54ebb3 Mon Sep 17 00:00:00 2001 From: lloan alas Date: Tue, 28 Nov 2023 08:09:38 -0800 Subject: [PATCH 1/2] implement feedback for telemetry --- .../layout/navigation/whatsnew/WhatsNewMenu.tsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/frontend/src/components/layout/navigation/whatsnew/WhatsNewMenu.tsx b/frontend/src/components/layout/navigation/whatsnew/WhatsNewMenu.tsx index 88c60abcc2..f3d3ce6e64 100644 --- a/frontend/src/components/layout/navigation/whatsnew/WhatsNewMenu.tsx +++ b/frontend/src/components/layout/navigation/whatsnew/WhatsNewMenu.tsx @@ -73,6 +73,7 @@ import { GiftIcon } from "../../../Icons"; import { useL10n } from "../../../../hooks/l10n"; import { VisuallyHidden } from "../../../VisuallyHidden"; import { useOverlayBugWorkaround } from "../../../../hooks/overlayBugWorkaround"; +import { useGaViewPing } from "../../../../hooks/gaViewPing"; export type WhatsNewEntry = { title: string; @@ -344,7 +345,11 @@ export const WhatsNewMenu = (props: Props) => { ? getPeriodicalPremiumSubscribeLink(props.runtimeData, "yearly") : undefined; - const yearlyPlanRefWithCoupon = `${yearlyPlanLink}&coupon=HOLIDAY20&utm_source=fx-relay&utm_medium=announcement&utm_campaign=holiday-promo-2023`; + const yearlyPlanRefWithCoupon = `${yearlyPlanLink}&coupon=HOLIDAY20&utm_source=relay.firefox.com&utm_medium=whatsnew-announcement&utm_campaign=relay-holiday-promo-2023`; + const getYearlyPlanBtnRef = useGaViewPing({ + category: "Holiday Promo News CTA", + label: "holiday-promo-2023-news-cta", + }); const holidayPromo2023: WhatsNewEntry = { title: l10n.getString("whatsnew-holiday-promo-2023-news-heading"), @@ -359,6 +364,7 @@ export const WhatsNewMenu = (props: Props) => { cta={ { gaEvent({ category: "Holiday Promo News CTA", From 1de2780ec3e74358309516deba8654cee57d5d64 Mon Sep 17 00:00:00 2001 From: lloan alas Date: Tue, 28 Nov 2023 09:25:50 -0800 Subject: [PATCH 2/2] update UTM params for banner --- .../src/components/layout/topmessage/HolidayPromoBanner.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/components/layout/topmessage/HolidayPromoBanner.tsx b/frontend/src/components/layout/topmessage/HolidayPromoBanner.tsx index dd8b3b940f..feccbb73b2 100644 --- a/frontend/src/components/layout/topmessage/HolidayPromoBanner.tsx +++ b/frontend/src/components/layout/topmessage/HolidayPromoBanner.tsx @@ -43,7 +43,7 @@ export const HolidayPromoBanner = (props: Props) => { } const utmParams = - "&utm_source=fx-relay&utm_medium=banner&utm_content=holiday-promo-banner-cta&utm_campaign=holiday-promo-2023"; + "&utm_source=fx-relay&utm_medium=banner&utm_content=holiday-promo-banner-cta&utm_campaign=relay-holiday-promo-2023"; const subscriberLinkWithCoupon = `${subscribeLink}&coupon=${coupon}${utmParams}`; return (