Bug 1254956 - Implement Node.rootNode. r=Ms2ger,smaug

MozReview-Commit-ID: HeV3qnngbTx --HG-- extra : rebase_source : b25172112a902a2dd4f9af2087a266baa7f8b797
mozilla · Mar 16, 2016 · 4967a99 · 4967a99
1 parent 2e624c1
commit 4967a99
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 38 deletions.
diff --git a/dom/base/nsINode.h b/dom/base/nsINode.h
@@ -943,6 +943,11 @@ class nsINode : public mozilla::dom::EventTarget
    */
   nsINode* SubtreeRoot() const;
 
+  nsINode* RootNode() const
+  {
+    return SubtreeRoot();
+  }
+
   /**
    * See nsIDOMEventTarget
    */

diff --git a/dom/webidl/Node.webidl b/dom/webidl/Node.webidl
@@ -37,6 +37,8 @@ interface Node : EventTarget {
   [Pure]
   readonly attribute Document? ownerDocument;
   [Pure]
+  readonly attribute Node rootNode;
+  [Pure]
   readonly attribute Node? parentNode;
   [Pure]
   readonly attribute Element? parentElement;

diff --git a/testing/web-platform/meta/dom/interfaces.html.ini b/testing/web-platform/meta/dom/interfaces.html.ini
@@ -291,18 +291,6 @@
   [DOMTokenList interface: calling supports(DOMString) on document.body.classList with too few arguments must throw TypeError]
     expected: FAIL
 
-  [Node interface: attribute rootNode]
-    expected: FAIL
-
-  [Node interface: xmlDoc must inherit property "rootNode" with the proper type (16)]
-    expected: FAIL
-
-  [Node interface: document.createDocumentFragment() must inherit property "rootNode" with the proper type (16)]
-    expected: FAIL
-
-  [Node interface: document.doctype must inherit property "rootNode" with the proper type (16)]
-    expected: FAIL
-
   [Element interface: element must inherit property "prepend" with the proper type (32)]
     expected: FAIL
 
@@ -324,15 +312,3 @@
   [Element interface: element must inherit property "replaceWith" with the proper type (42)]
     expected: FAIL
 
-  [Node interface: element must inherit property "rootNode" with the proper type (16)]
-    expected: FAIL
-
-  [Node interface: document.createTextNode("abc") must inherit property "rootNode" with the proper type (16)]
-    expected: FAIL
-
-  [Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "rootNode" with the proper type (16)]
-    expected: FAIL
-
-  [Node interface: document.createComment("abc") must inherit property "rootNode" with the proper type (16)]
-    expected: FAIL
-
diff --git a/testing/web-platform/meta/dom/nodes/rootNode.html.ini b/testing/web-platform/meta/dom/nodes/rootNode.html.ini