Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

SameSite support #143

Open
xacx opened this issue Jan 31, 2020 · 8 comments
Open

SameSite support #143

xacx opened this issue Jan 31, 2020 · 8 comments

Comments

@xacx
Copy link

xacx commented Jan 31, 2020

Are there plans for sameSite support for chrome 80 or is it alreay supported?

@xacx
Copy link
Author

xacx commented Feb 14, 2020

sameSite=none is not supported until package.json is updated. Temporary workaroud avaialble is
cd node_modules/client-sessions
npm install [email protected]

@jcheng5
Copy link

jcheng5 commented Mar 31, 2020

This is pretty important now 😬

@drc-tjuszczyk
Copy link

@jcheng5 @xacx Can anyone still confirm that the cookies update is the only thing needed?

@jcheng5
Copy link

jcheng5 commented May 21, 2020

Yep--#142 works for me. (You do need to include cookie: {sameSite: "none"} in your session() options if you want that to be set, in case that wasn't obvious)

@drc-tjuszczyk
Copy link

the documentation just says it's "true" by default or something so no, it was no obvious lol. Thank you!

@jcheng5
Copy link

jcheng5 commented May 21, 2020

I mean, that's assuming that you do want your cookies to have SameSite=None. And if you do, you probably also need to use https://www.npmjs.com/package/should-send-same-site-none.

@xacx
Copy link
Author

xacx commented May 22, 2020

FYI, Chrome has rolled back the change https://blog.chromium.org/2020/04/temporarily-rolling-back-samesite.html

@vit100
Copy link

vit100 commented Oct 28, 2020

My buddy forked this repo and updated packages.json. If interested here it is:
https://github.com/nvanexan/node-client-sessions

and here is npm package:
@nvanexan/node-client-sessions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants