You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This unit-test was already tweaked once in PR #17663, maybe we should try changing the divisor to 3 instead?
Obviously comparing parsing/rendering times like this isn't great, but I don't know how we'd test this otherwise.
we use a divisor of 2 and I don't recall having seen that one fail, so I have made the PR above to go use that divisor for this test too for consistency.
There's one more thing that we could try, if these tweaks don't help, however it'd increase the runtime of these tests quite a bit and should probably only be a last resort.
Basically we could repeat the contents of these test-cases e.g. five times, and keep the stats for all runs. Then we'd discard the lowest/highest values and compute the average of the remaining ones and finally compare those averages.
This unit test failed most recently in http://54.193.163.58:8877/0936bcbf5dcdb06/output.txt on Windows, but has failed a couple of times before on Linux too. The log line is:
We should investigate why this happens sometimes because as far as I have seen this is the only intermittent we have left in the unit tests.
The text was updated successfully, but these errors were encountered: