Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image elements missing #4890

Closed
automatedbugreportingfacility opened this issue Jun 4, 2014 · 1 comment · Fixed by #4892
Closed

Image elements missing #4890

automatedbugreportingfacility opened this issue Jun 4, 2014 · 1 comment · Fixed by #4892
Labels
image-jpeg image-quality regression

Comments

@automatedbugreportingfacility
Copy link

This is a regression. A part of an image isn't rendered anymore.

URL: http://www.sunnuclear.com/documents/DQA3.pdf
1.0.291: http://i.imgur.com/QjYdSaR.png
0.8.990: http://i.imgur.com/XUpLJCB.png

e8f0700 is the first bad commit
commit e8f0700
Author: Thorben Bochenek
Date: Thu Mar 27 17:08:32 2014 +0100

Move the colour conversion to jpg.js

Benchmarking shows that this improves performance for the invitation document
from https://github.com/mozilla/pdf.js/issues/3809 by 35%
@timvandermeij
Copy link
Contributor

/cc @bthorben

@yurydelendik yurydelendik mentioned this issue Jun 4, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
image-jpeg image-quality regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes masked JPEG image yurydelendik/pdf.js
2 participants
@timvandermeij @automatedbugreportingfacility