From 62db66dd4645efadc896f628ac7a5b3067a06e77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Tue, 10 Dec 2024 12:00:09 +0100 Subject: [PATCH] Simplify logic to insert canvas as first element Instead of conditionally checking if the `.cavnasWrapper` already has a child element and then inserting the `canvas` before it, we can use `.prepend` which always injects the new element as the first child. --- web/pdf_page_view.js | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/web/pdf_page_view.js b/web/pdf_page_view.js index 83766a78ad442..26b3257f93ec3 100644 --- a/web/pdf_page_view.js +++ b/web/pdf_page_view.js @@ -989,12 +989,7 @@ class PDFPageView { // drawing is complete when `!this.renderingQueue`, to prevent black // flickering. // In whatever case, the canvas must be the first child. - const { firstChild } = canvasWrapper; - if (firstChild) { - firstChild.before(canvas); - } else { - canvasWrapper.append(canvas); - } + canvasWrapper.prepend(canvas); showCanvas = null; return; } @@ -1006,12 +1001,7 @@ class PDFPageView { prevCanvas.replaceWith(canvas); prevCanvas.width = prevCanvas.height = 0; } else { - const { firstChild } = canvasWrapper; - if (firstChild) { - firstChild.before(canvas); - } else { - canvasWrapper.append(canvas); - } + canvasWrapper.prepend(canvas); } showCanvas = null;