-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rhino for Android #282
Comments
Just include rhino in your project using gradle and it works... |
@TheDiamondYT1 But only in interpreted mode, and JavaAdapter can't be used. |
I tried to run sample project of |
@AlexTrotsenko where did you get that number from? I've just tested it with the Pi computation. For me interpreted mode is faster until about 10.000 iterations. After about 100.000 iterations compiled mode goes down to about 70% of interpreted mode, but I can't reach multitudes of 2, let alone 3. |
These are my results for 10.000.000 iterations |
Hello @F43nd1r , thanks for reply. Following is my data. I will push my code soon. With optimisation:
Without optimisation:
|
@F43nd1r Here is the source code of the my changes. The important part is that I do |
If someone decide to add support for "compiled" mode: looks like Byte Buddy supports both Java and Android byte code generation - thus it could be a good option for |
@AlexTrotsenko I've looked at what Bytebuddy does under the hood and its no different to what my library does. So, I believe using bytebuddy wouldn't give any different results. Rhino is good at generating bytecode (for its usecases), so unless a library directly generates dex code, I'd be surprised to see any significant performance increase. |
@F43nd1r you are right, there might be no big difference in performance. I suggested Bytebuddy because it seams like good candidate for unification of java code, which generates new byte code for both Also I have issues, when I re-start or re-install my app with new changes. You can use my project above for testing. Following is 2 examples of recent exceptions:
and followed by
P.S. I tried once again performance of compiled with not-compiled Rhino, now for calculating of fibonacci numbers. This time for 10000 iteration I had difference of 2.9 sec vs 2.3 sec. |
You seem to be using an old version of my library. Try with 1.5 |
@F43nd1r you are right, I was using 1.4, but it's strange as Now I run the app on Pixel 2 XL, Android 8.1 and got following exception on re-start:
Very similar is on Nexus 5, Android 6.0.1
|
This is still not
Maven sync failed on |
I'm sorry for beeing uninformed, but I'm not a programmer, just want to use Rhino to draw some designs and machine parts. Or is this some other, different Rhino? |
@filozirka this is a javascript engine, you are probably talking about rhino3d.com, which is not related to this at all. |
I am the creator of the wrapper for Rhino on Android.
It is generally working well. However, there are ~80 failing Tests that I either don't know what they should do or don't know how to fix.
Is there anybody with some insight on Rhino and its tests who would be willing to look at the tests run on an Android device?
(I can give precise directions on how to setup the testing environment if needed.)
Note: I posted about some of these tests in #211, but did not receive any answer.
The text was updated successfully, but these errors were encountered: