Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split the Map and Set traits into Map, MutableMap, PersistentMap and Set, MutableSet, PersistentSet #4989

Closed
thestinger opened this issue Feb 17, 2013 · 5 comments
Closed

split the Map and Set traits into Map, MutableMap, PersistentMap and Set, MutableSet, PersistentSet #4989

thestinger opened this issue Feb 17, 2013 · 5 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@thestinger
Copy link
Contributor

This needs to be done in order to implement the traits for compile-time maps/sets and persistent maps/sets. There's only std::fun_treemap at the moment and it's not self-balancing yet, so this isn't a high priority.
@emberian
Copy link
Member

Triage bump

@sfackler sfackler mentioned this issue Jul 13, 2013
Merged
sfackler added a commit to sfackler/rust that referenced this issue Jul 14, 2013
@sfackler
Split mutable methods out of Set and Map
6b37b5b 
Fixes most of rust-lang#4989. I didn't add Persistent{Set,Map} since the only
persistent data structure is fun_treemap and its functionality is
currently too limited to build a trait out of.
bors added a commit that referenced this issue Jul 14, 2013
@bors
auto merge of #7768 : sfackler/rust/containers, r=huonw
0ef8375 
See #4989. I didn't add Persistent{Set,Map} since the only
persistent data structure is fun_treemap and its functionality is
currently too limited to build a trait out of.
@bluss
Copy link
Member

bluss commented Jul 31, 2013

this was fixed in pull #7768

@sfackler
Copy link
Member

#7768 didn't add the Persistent{Map,Set} traits.

@bluss
Copy link
Member

bluss commented Jul 31, 2013

I'm sorry, for some reason I didn't see those at all

@thestinger
Copy link
Contributor Author

I think the Persistent traits can be handled by a different issue report once we actually have useful persistent containers.

bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#4989 - rust-lang:no-unmangled-must-use, r=fli…
fddc980 
…p1995

No #[no_mangle] must_use_candidate functions

This fixes rust-lang#4984.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@emberian @sfackler @thestinger @bluss