Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot filter based on the displayed name in /revisions page #2019

Closed
emilghittasv opened this issue Oct 24, 2024 · 6 comments
Closed

Cannot filter based on the displayed name in /revisions page #2019

emilghittasv opened this issue Oct 24, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@emilghittasv
Copy link
Collaborator

Preconditions
Sign in to SUMO with a contributor account.

Steps to reproduce
Steps to reproduce the behavior:

  1. Go to https://support.allizom.org/en-US/kb/revisions
  2. Type "Smith" inside the "Users" filter.

Expected behavior
The revisions can be filtered for both username and display names

Actual behavior
The revisions are not filtered based on "Smith" which is the display name of the sellis1 username. The problem here is that contributors might try filtering via the value which is displayed inside the "Editor" column.

If the username has a set display name, the display name will take priority and it will be displayed inside the "Editor" column instead of the username which makes it hard for users to figure out which is the actual username and based on what should they perform the search.

Screencasts
recentRevisionsFilter

Desktop:

  • OS: Windows 11
  • Browser: Firefox

Additional context
This issue is reproducible on both stage and prod.

@emilghittasv emilghittasv added the bug Something isn't working label Oct 24, 2024
@github-project-automation github-project-automation bot moved this to ❓ triage in Mozilla Support Oct 24, 2024
@akatsoulas akatsoulas moved this from ❓ triage to 🗄 backlog in Mozilla Support Oct 29, 2024
@smithellis
Copy link
Collaborator

mozilla/kitsune#6348

@smithellis smithellis self-assigned this Nov 11, 2024
@smithellis smithellis moved this from 🗄 backlog to 📚 review in Mozilla Support Nov 11, 2024
@smithellis
Copy link
Collaborator

mozilla/kitsune#6351

@emilghittasv
Copy link
Collaborator Author

@smithellis I'm still able to reproduce this issue in stage.

Trying to search (inside the /revisions page) for Smith in the Users field will not return only the search results containing the contributions made by your profile. Searching for the username sellis1 will successfully return only your contributions. So searching for display name is still not working in this case.

I'm moving this ticket back inside the in progress column.

@emilghittasv
Copy link
Collaborator Author

@smithellis Now that the patch has landed in stage after the pod fix I've redone the verification.

Unfortunately (as it can be seen in the attached screencast for this comment) the recent revisions page is not filtering data based on the display name.

Image

@smithellis
Copy link
Collaborator

mozilla/kitsune#6361

This may be a speed/timing issue. This PR attempts to improve the speed and quality of the user lookup.

@emilghittasv
Copy link
Collaborator Author

I can confirm that the /revisions page can be filter by both displayed names & usernames in stage.

Moving this ticket inside the release column.

@github-project-automation github-project-automation bot moved this from 🚢 release to ✔ done in Mozilla Support Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants