Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Some odd closing tags like </ modal -link> in some locales #3986

Open
pdehaan opened this issue Nov 13, 2018 · 0 comments
Open

Some odd closing tags like </ modal -link> in some locales #3986

pdehaan opened this issue Nov 13, 2018 · 0 comments

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Nov 13, 2018

I'm noticing some odd closing tags like </ modal -link> in some cases. Not sure how to check globally for those, or if they're even broken in the front end for those locales.

Possibly closer to a solution, although very ignorant greppin' on my part:

$ git grep "<modal-link>" locales/*/experiments.ftl | grep -v "</modal-link>"

# `</ terms-link>`, `</ privacy-link>`, and `</ modal -link>`:
1. locales/cy/experiments.ftl:emailtabsLegalnotice = Wrth fynd ymlaen, rydych chi'n cytuno ar y termau <terms-link> terms </ terms-link> a <privacy-link> privacy </ privacy-link> polisïau Prawf Peilot a'r polisi preifatrwydd <modal-link> Email Tabs </ modal -link>.

# `</ terms-link>`, `</ privacy-link>`, and `</ modal -link>`:
2. locales/cy/experiments.ftl:pricewiseLegalnotice = Drwy barhau, rydych chi'n cytuno i<terms-link>delerau</ terms-link> a pholisiau<privacy-link> preifatrwydd</ privacy-link> Test Pilot a pholisi preifatrwydd <modal-link>Price Wise</ modal -link>.

# Empty `<terms-link> </terms-link>`, and `</modal -link>`:
3. locales/es-AR/experiments.ftl:emailtabsLegalnotice = Al continuar, acepta los términos <terms-link> </terms-link> y <privacy-link> las políticas de privacidad </privacy-link> de Test Pilot y la <modal-link> política de privacidad de Email Tabs  </modal -link>.

# Empty `<terms-link> </terms-link>`, and `</ modal-link>`:
4. locales/es-AR/experiments.ftl:pricewiseLegalnotice = Al continuar, estás aceptando los términos <terms-link> </terms-link> y <privacy-link> privacidad </privacy-link> de las políticas de Test Pilot y la <modal-link> política de privacidad de Price Wise </ modal-link>.

# Invalid `<terms-link>términos</>`, and `<privacy-link>privacidad</terms-link>`, and `<modal-link>Políticas de privacidad de Notes</privacy-link>`:
5. locales/es-MX/experiments.ftl:notesLegalnoticeWithlinks = Al proceder, aceptas los <terms-link>términos</> y las políticas de <privacy-link>privacidad</terms-link> de Test Pilot y la <modal-link>Políticas de privacidad de Notes</privacy-link>.

# `</ terms-link>`, `</ privacy-link>`, and `</ modal -link>`:
6. locales/nl/experiments.ftl:pricewiseLegalnotice = Door verder te gaan, gaat u akkoord met de <terms-link>voorwaarden</ terms-link> en beleidsregels voor <privacy-link>privacy</ privacy-link> van Test Pilot en het <modal-link>privacybeleid van Price Wise</ modal -link>.

Originally posted by @pdehaan in #3985

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant