Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Ensure UA override works for redirects #1261

Merged
merged 1 commit into from
May 24, 2019
Merged

Ensure UA override works for redirects #1261

merged 1 commit into from
May 24, 2019

Conversation

bluemarvin
Copy link
Contributor

No description provided.

@bluemarvin bluemarvin added the bug This issue is a software or functional defect label May 24, 2019
@bluemarvin
Copy link
Contributor Author

The code removed for this PR was originally for a fix to GeckoView where we would get onLoadRequest() for elements in the page such as iframes that would cause UA override to get disabled. That issue has now been fixed in GeckoView. However, that old fix depended on onPageStop() to reset the UA override flag. Unfortunately redirects do not call onPageStop() so the flag was never getting reset and the UA override was not being checked for redirected pages.

@MortimerGoro MortimerGoro merged commit 1334eb2 into master May 24, 2019
@philip-lamb philip-lamb deleted the on-load-request-redirect branch May 29, 2019 06:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MortimerGoro MortimerGoro MortimerGoro approved these changes

@philip-lamb philip-lamb philip-lamb approved these changes

Assignees
No one assigned
Labels
bug This issue is a software or functional defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluemarvin @MortimerGoro @philip-lamb