Don't send empty username and password #1197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 70a247c changed how we generate options, we now end up sending an empty username and password when they are not set, instead of sending no username and password. This ends up confusing some MQTT servers, which don't properly detect an empty username/password as an anonymous login.
This can be seen most clearly in the connect flags:
b5b3814 (one commit before 70a247c)
70a247c
Setting the options to null when they're false-y seems to fix this.