Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): use worker timers to prevent unexpected client close #1753

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

robertsLando
Copy link
Member

Fixes #1257

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a50e85c) 79.45% compared to head (0c1ed0a) 79.54%.

Files Patch % Lines
src/lib/PingTimer.ts 86.66% 0 Missing and 2 partials ⚠️
src/lib/shared.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
+ Coverage   79.45%   79.54%   +0.09%     
==========================================
  Files          23       24       +1     
  Lines        1402     1418      +16     
  Branches      329      332       +3     
==========================================
+ Hits         1114     1128      +14     
  Misses        209      209              
- Partials       79       81       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertsLando robertsLando changed the title feat(browser): use worker timers fix(browser): use worker timers to unexpected client close Dec 4, 2023
@robertsLando robertsLando changed the title fix(browser): use worker timers to unexpected client close fix(browser): use worker timers to prevent unexpected client close Dec 4, 2023
@robertsLando robertsLando merged commit 35448f3 into main Dec 4, 2023
10 checks passed
@robertsLando robertsLando deleted the feat-retimer branch December 4, 2023 16:30
This was referenced Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT keepalive less than 60s and chrome 88 intensive timer throttling
1 participant