fix: tets hang up

[MaximoLiberata]

Fixes (#1897 (comment)).

When you try to execute the tests maybe one of them will fail because it hanged up and never ends. This PR fix that bug in almost all cases.

[MaximoLiberata]

@robertsLando try to execute this PR many times and give me feedback if it working right, please.

[robertsLando]

Thanks for this PR @MaximoLiberata ! I hope you are right, unfortunately I will not be on my pc till Monday but I will definitely look at this ASAP! I checked the changes and it feels strange only this test was causing the issue, my feel was that there were many of them with this same problem. Did they always succeed now or they just fail less?

[MaximoLiberata]

I'm glad to contribute.

The short answer, they just fail less. There are some more bugs might hang up the tests, but I haven't found the cause yet. I tried to cover all the tests as async/await or change the logic of tests; however, the tests failed. This test in specific was the main bug that hang up other tests that call abstract_client.ts.

On the other hand, when the server is closed or hang up, the tests that use it will hang up. We need to careful with the use of sinon and server, they can create global bugs and affect other unit tests.

Until now, I executed the tests using npm test many times and they hardly ever fail.

[robertsLando]

Thanks! 🙏🏼 LGTM

[robertsLando]

@MaximoLiberata Tests seems much more reliable now! Thanks again 🙏🏼

[MaximoLiberata]

I'm glad to hear! And thank you for checking 🙏🏼.