Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): reuse client when viewing git dependencies #374

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix(lsp): reuse client when viewing git dependencies #374

merged 1 commit into from
Apr 26, 2024

Conversation

eero-lehtinen
Copy link
Contributor

Fixes: #373

@github-actions GitHub Actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

mrcjkb
mrcjkb approved these changes Apr 26, 2024
View reviewed changes
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@mrcjkb mrcjkb merged commit 987f230 into mrcjkb:master Apr 26, 2024
6 checks passed
This was referenced Nov 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcjkb mrcjkb mrcjkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git dependencies get erroneously added as workspaces
2 participants
@eero-lehtinen @mrcjkb