(r158 nodes) Webpack error in ModelNode

[njarraud]

Description

I tried to upgrade from r155 to r158 to check the latest improvements of the node system however webpack throws an error on start up. (I use Next.js)

It seems to be related to the temp function called in accessors/ModelNode.js

export const modelViewMatrix = nodeImmutable( ModelNode, ModelNode.VIEW_MATRIX ).temp( 'ModelViewMatrix' );

Reproduction steps

1. Use three r158 in a project that uses webpack

Code

Live example

None

Screenshots

No response

Version

r158

Device

No response

Browser

No response

OS

No response

[CodyJasonBennett]

Does this persist if you remove "sideEffects": false from three's package.json? That tells Webpack it can skip entire directories if unreferenced in code, but Nodes specifically are quite effectful to populate these methods and perhaps should be globbed with this property.

[TobiasNoell]

We are having the same problem in an Angular app when going from 157 to 158

Uncaught TypeError: (0 , _shadernode_ShaderNode_js__WEBPACK_IMPORTED_MODULE_1__.nodeImmutable)(...).temp is not a function
    at 1632 (ModelNode.js:26:82)
    at __webpack_require__ (bootstrap:19:1)
    at 50116 (MorphNode.js:70:1)
    at __webpack_require__ (bootstrap:19:1)
    at 22487 (luminance-node.ts:26:2)
    at __webpack_require__ (bootstrap:19:1)
    at 37149 (material-exporter.ts:288:2)
    at __webpack_require__ (bootstrap:19:1)
    at 33655 (orbit-controls.ts:742:2)
    at __webpack_require__ (bootstrap:19:1)

[TobiasNoell]

Does this persist if you remove "sideEffects": false from three's package.json? That tells Webpack it can skip entire directories if unreferenced in code, but Nodes specifically are quite effectful to populate these methods and perhaps should be globbed with this property.

Removing "sideEffects": false from three's package.json does not seem to help

[Mugen87]

Related PR #26881.

[Mugen87]

What version of Webpack are you using?

[TobiasNoell]

What version of Webpack are you using?

[email protected]

[njarraud]

Webpack 5.86

[mlt131220]

What version of Webpack are you using?

vite/4.4.7 win32-x64 node-v16.18.0

[TobiasNoell]

Does this persist if you remove "sideEffects": false from three's package.json? That tells Webpack it can skip entire directories if unreferenced in code, but Nodes specifically are quite effectful to populate these methods and perhaps should be globbed with this property.

Removing "sideEffects": false from three's package.json does not seem to help

@CodyJasonBennett: Actually, I was wrong about it (it was still using a cached version in my test before):
Removing "sideEffects": false from package.json indeed seems to help!

[Mugen87]

Could one of the Webpack users also report this issue to the Webpack repository?

It seems it is not clear yet why the build-tool is failing in ModelNode. The code itself works but for some reasons Webpack doesn't understand it.

[eytienne]

I added the following Webpack rule to address this issue:

{
	test: /node_modules\/three\/examples\/jsm\/nodes\/.*\.(ts|js)$/,
	use: {
		loader: 'babel-loader',
	},
	sideEffects: true
},

[Hoodgail]

I'm having the same issue with vite

[seancheno]

We are experiencing this issue as well. Spent about 2 days now trying to get past it. We are using ts and vite. When I import MeshPhysicalNodeMaterial from "three/examples/jsm/nodes/materials/MeshPhysicalNodeMaterial"; we get the error index.js:5273 Uncaught (in promise) TypeError: We(...).label is not a function for const iu = We(Br, Br.VIEW_MATRIX).label("modelViewMatrix").temp("ModelViewMatrix")