Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Linter fails on 1.0 branch #247

Closed
3 tasks
SemyonSinchenko opened this issue Jul 15, 2024 · 1 comment
Closed
3 tasks

feat: Linter fails on 1.0 branch #247

SemyonSinchenko opened this issue Jul 15, 2024 · 1 comment
Labels
1.0 Quinn 1.0 release

Comments

@SemyonSinchenko
Copy link
Collaborator

Feature Type

  • Adding new functionality to quinn

  • Changing existing functionality in quinn

  • Removing existing functionality in quinn

Problem Description

https://github.com/MrPowers/quinn/actions/runs/9935547834/job/27441930563

installing ruff from spec 'ruff==0.5.1'...
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'isort' -> 'lint.isort'
quinn/schema_helpers.py:1[34](https://github.com/MrPowers/quinn/actions/runs/9935547834/job/27441930563#step:4:36):37: F821 Undefined name `Optional`
    |
132 |         return type_lookup[type_str]
133 | 
134 |     def _convert_nullable(null_str: Optional[str]) -> bool:
    |                                     ^^^^^^^^ F821
1[35](https://github.com/MrPowers/quinn/actions/runs/9935547834/job/27441930563#step:4:37) |         if null_str is None:
1[36](https://github.com/MrPowers/quinn/actions/runs/9935547834/job/27441930563#step:4:38) |             return True
    |

Found 1 error.
Error: Process completed with exit code 1.

Feature Description

Fix linter problems in 1.0

Additional Context

No response

@SemyonSinchenko SemyonSinchenko added the 1.0 Quinn 1.0 release label Jul 15, 2024
@fpgmaas
Copy link

fpgmaas commented Jul 15, 2024

Should be solved by #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Quinn 1.0 release
Projects
None yet
Development

No branches or pull requests

2 participants