From 457e02af17e2c593e3209ff1938342247ee36e0a Mon Sep 17 00:00:00 2001 From: Momo Kornher Date: Mon, 20 Nov 2023 13:57:09 +0100 Subject: [PATCH 1/2] chore: pr-build failing with unsafe-perm is not a valid npm option (#28068) We switched the images used to build PRs to `jsii/superchain:bullseye-slim-node18` which comes with Node.js 18 instead of Node.js 16. This Node.js upgrade also includes an upgraded version of npm, and in recent npm versions, the unsef-perm option is not required anymore. This change simply removes the now redundant command. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- buildspec-pr.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/buildspec-pr.yaml b/buildspec-pr.yaml index 1168f54b338ae..852070e934e86 100644 --- a/buildspec-pr.yaml +++ b/buildspec-pr.yaml @@ -14,9 +14,6 @@ phases: # this also takes care of launching the docker daemon. - /root/ecr-proxy/start.sh - # CodeBuild always runs as root, allow npm to operate as such - - npm config set unsafe-perm true - # Install yarn if it wasn't already present in the image - yarn --version || npm -g install yarn From ebd0cd311cab52478ddf99b629d5dc9ff2b95363 Mon Sep 17 00:00:00 2001 From: Momo Kornher Date: Mon, 20 Nov 2023 14:55:31 +0100 Subject: [PATCH 2/2] chore: build failing with unsafe-perm is not a valid npm option (#28069) We switched the images used to run our main build to jsii/superchain:bullseye-slim-node18 which comes with Node.js 18 instead of Node.js 16. This Node.js upgrade also includes an upgraded version of npm, and in recent npm versions, the unsef-perm option is not required anymore. This change simply removes the now redundant command. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- buildspec.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/buildspec.yaml b/buildspec.yaml index 9efaf655e95c1..b54c07f3b99c1 100644 --- a/buildspec.yaml +++ b/buildspec.yaml @@ -10,9 +10,6 @@ phases: # this also takes care of launching the docker daemon. - /root/ecr-proxy/start.sh - # CodeBuild always runs as root, allow npm to operate as such - - npm config set unsafe-perm true - # Install yarn if it wasn't already present in the image - yarn --version || npm -g install yarn