Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why adding nms_embedding_feat and nms_attention_1 together #30

Open
happynewya opened this issue Sep 13, 2018 · 0 comments
Open

why adding nms_embedding_feat and nms_attention_1 together #30

happynewya opened this issue Sep 13, 2018 · 0 comments

Comments

@happynewya
Copy link

I don't understand codes below, in
resnet_v1_101_rcnn_attention_1024_pairwise_position_multi_head_16_learn_nms.py

You added one of Relation Module inputs and Relation Module output together as the input of later layer. But you did not explain why you do this in your paper.

nms_attention_1, nms_softmax_1 = self.attention_module_nms_multi_head(
                nms_embedding_feat, nms_position_matrix,
                num_rois=first_n, index=1, group=16,
                dim=(1024, 1024, 128), fc_dim=(64, 16), feat_dim=128
)
nms_all_feat_1 = nms_embedding_feat + nms_attention_1

I think that the network figure should add the green path
image

btw, nms_softmax_1 is redundant, I personally recommend deleting it in your release code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant