Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request handler should allow returning undefined or void #280

Closed
kettanaito opened this issue Jul 15, 2020 · 0 comments · Fixed by #253
Closed

Request handler should allow returning undefined or void #280

kettanaito opened this issue Jul 15, 2020 · 0 comments · Fixed by #253
Assignees
@kettanaito
Labels
bug Something isn't working
Milestone
0.20.0

Comments

@kettanaito
Copy link
Member

Current behavior

Returning undefined or void raises a TypeScript error.

Expected behavior

Request handler should allow returning undefined or void. This way request handlers support a fall-through functionality, as well as short-circuiting.
@kettanaito kettanaito added the bug Something isn't working label Jul 15, 2020
@kettanaito kettanaito self-assigned this Jul 15, 2020
@kettanaito kettanaito added this to the 0.20.0 milestone Jul 15, 2020
@jensmeindertsma jensmeindertsma mentioned this issue Jul 15, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kettanaito kettanaito

Labels
bug Something isn't working
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

Added feature: res.networkError() mocks a network error
1 participant
@kettanaito