"cookie" module has no default export

[cgatian]

Describe the bug

This is more of a convenience issue, than bug.

Performing a build with TypeScript 3.9.5 with allowSyntheticDefaultImports disabled displays:

ERROR in node_modules/msw/lib/types/context/cookie.d.ts:1:8 - error TS1192: Module '"/node_modules/@types/cookie/index"' has no default export.

Now the issue is because my TypeScript config is strict, and I can modify it to either ignore libraries or allow the synthetic import. However, it might be better to update areas of the code that are doing this:

import cookieUtils from 'cookie'

To

import { parse } from 'cookie'

Since the library definitions accurately reflect no default export on the cookie package.

I also could have all this wrong... I don't claim to be an expert in any of this

Environment

• msw: 0.20.1
• nodejs: 14.2.0
• npm: 6.14.5

Please also provide your browser version.

To Reproduce

Steps to reproduce the behavior:

1. Configure TypeScript compilation without allowSyntheticDefaultImports
2. Import import { setupWorker, rest } from 'msw'; somewhere in code
3. TypeScript compilation issue

Expected behavior

No compilation errors

Screenshots

If applicable, add screenshots to help explain your problem.

[kettanaito]

Hey, @cgatian! Thanks for letting us know about this.

I've tackled this by setting allowSyntheticDefaultImports: false in our tsconfig.json. This change has reported this, and some other violations, which I've addressed. Expect the changes to be merged soon.

[cgatian]

Thanks for being open to the suggestion. This should improve the quality of life for consumers of this lib. 👍

[kettanaito]

The changes are published in 0.20.2. Please update and let us know that it compiles without TypeScript errors now.

[cgatian]

Works great. Thank you!