-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mingw-w64-x86_64-qgpgme-qt5: use of IMPORTED_IMPLIB_RELEASE breaks non-release CMake builds #22993
Comments
Please provide steps to reproduce the issue. Also, the cmake does not seem from msys2. |
CMakeLists.txt: cmake_minimum_required(VERSION 3.19)
project(gpgme2 C CXX)
find_package(Qt5 COMPONENTS Core REQUIRED)
find_package(QGpgme REQUIRED)
add_executable(main main.cpp)
target_link_libraries(main PUBLIC QGpgme) main.cpp: int main() {
return 0;
} Configuring with a recent enough CMake detects the error:
This is patently clear in the contents of QGpgmeConfig.cmake lines 69 onwards:
And reviewing the patch that MSYS2 ships should've detected this bug on the spot (as it's a system artifact, the highlighted lines should not read MINGW-packages/mingw-w64-gpgme/relocatable-cmake.patch Lines 59 to 62 in 8817853
|
Thanks, I can reproduce the issue which should be fixed in upstream.
Meanwhile, if you have any patch to fix the warning please create a pull request. |
I think the issue is fixed now. |
Description / Steps to reproduce the issue
mingw-w64-x86_64-qgpgme-qt5
.find_package(QGpgme)
on any project.QGpgme
target.Expected behavior
Link should succeed.
Actual behavior
This is because the import library as provided by MSYS2 is qualified for only the
Release
build type.Verification
Windows Version
MINGW64_NT-10.0-19045
MINGW environments affected
Are you willing to submit a PR?
As soon as I get confirmation from a maintainer
The text was updated successfully, but these errors were encountered: