Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid Owner Checker should ignore team name casing #77

Closed
kenherring opened this issue Jul 7, 2021 · 0 comments · Fixed by #78
Closed

Valid Owner Checker should ignore team name casing #77

kenherring opened this issue Jul 7, 2021 · 0 comments · Fixed by #78
Assignees
Labels
bug Something isn't working

Comments

@kenherring
Copy link

Description

We have a code owners file with the following entries:

src/somefile1.txt @someorg/teamreviewers
src/somefile2.txt @someorg/TeamReviewers

Under the "someorg" organization we have a team called "TeamReviewers". The validator currently issues an error for the second entry above. It appears that we expect to use only lowercase names.

version.Info{Version:"0.6.0", GitCommit:"2f6e3bb", BuildDate:"2021-01-22T09:50:03Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"linux/amd64"}
==> Executing Valid Syntax Checker (530.724µs)
    Check OK
==> Executing Duplicated Pattern Checker (356.498µs)
    Check OK
==> Executing File Exist Checker (23.789863ms)
    Check OK
==> Executing Valid Owner Checker (670.5905ms)
    [err] line 2: Team "TeamReviewers" does not exist in organization "someorg".

Expected result

In the instance described above both entries should ignore casing and match "TeamReviewers".

Actual result

==> Executing Valid Owner Checker (670.5905ms)
    [err] line 2: Team "TeamReviewers" does not exist in organization "someorg".

Steps to reproduce

  1. Setup a team name that is not all lower case.
  2. Add an entry to the CODEOWNERS file using the non-lowercase format.
  3. Run the validator.

Troubleshooting

We have changed our CODEOWNERS file to use all lowercase names, but this isn't ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants