Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How could we handle card like [[Tournament Grounds]]? #23

Open
aloisdg opened this issue May 8, 2020 · 1 comment
Open

How could we handle card like [[Tournament Grounds]]? #23

aloisdg opened this issue May 8, 2020 · 1 comment

Comments

@aloisdg
Copy link

aloisdg commented May 8, 2020

Hello,

I was working to adjust this list. How could we handle specific land like [[Tournament Grounds]]?

To handle it we would have to add some "awareness" about what card we can play. How hard would it be to handle it?

Thank you for your work!

Cheers,

@jshrake
Copy link
Contributor

jshrake commented May 23, 2020

Thanks for the issue! Handling card specific text is outside of the scope I want for the project at this time. The project is essentially in maintenance at this point and I do not intend to perform any significant updates, outside of releasing updates for new card sets or changes in the mulligan strategy.

To handle it we would have to add some "awareness" about what card we can play. How hard would it be to handle it?

Handling it would require changing a few different pieces of code:

  • Account for card subtypes (Knights, Equiment, etc.). Right now, the code really only handles land types.
  • Create a new field on the Card struct to to restrict spending mana to certain subtypes. (something like mana_spend_restrictions: Vec<CardKind>)
  • Update the code to take the restriction into account when determining if a mana source can be spent on a particular card.
  • Write some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants