Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PokemonSprites with new properties. #33

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Update PokemonSprites with new properties. #33

merged 3 commits into from
Jun 17, 2022

Conversation

Schinwinkwinsky
Copy link
Contributor

No description provided.

jtwotimes
jtwotimes requested changes Jun 10, 2022
View reviewed changes
Copy link
Owner

@jtwotimes jtwotimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes needed to get this fully working for all the added fields.

PokeApiNet/Models/Pokemon.cs Outdated Show resolved Hide resolved
PokeApiNet/Models/Pokemon.cs Outdated Show resolved Hide resolved
jtwotimes
jtwotimes requested changes Jun 14, 2022
View reviewed changes
Copy link
Owner

@jtwotimes jtwotimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change

PokeApiNet/Models/Pokemon.cs Outdated Show resolved Hide resolved
@jtwotimes jtwotimes merged commit 72eb9a3 into jtwotimes:master Jun 17, 2022
@Schinwinkwinsky Schinwinkwinsky deleted the update-pokemonsprites-with-new-properties branch June 17, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtwotimes jtwotimes jtwotimes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schinwinkwinsky @jtwotimes