[Tooltip] Fix hover issues #12394
Merged
[Tooltip] Fix hover issues #12394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,12 +160,15 @@ class Tooltip extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| if (event.type === 'mouseenter') { | |||
| if (event.type === 'mouseenter' || event.type === 'mouseover') { | |||
| this.internalState.hover = true; | |||
|
|
|||
| if (childrenProps.onMouseEnter) { | |||
There was a problem hiding this comment.
What do you think of removing this handler?
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
tooltipfix
branch
from
54120de to
406a246
Compare
oliviertassinari
force-pushed
the
tooltipfix
branch
from
406a246 to
6fad1ca
Compare
|
@aseem191 It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
This was referenced Mar 26, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in #12289 describes the issue of one Tooltip preventing the firing of another Tooltip that the first Tooltip is over. This is a fix for that issue.
Closes #12289