-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Collapse] Add support for unitless collapsedHeight #18461
Conversation
Details of bundle changes.Comparing: 508f9a3...fa6a6af
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the trick only work on Chrome. It's brittle, I don't think that we should move forward with it. Instead, it seems more flexible to assume the pixel unit if none is provided. In the future, we might want to explore https://developers.google.com/web/updates/2018/03/cssom (as browser support increase)
Closes #18435