[docs] Reduce confusion in picker link #18566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While i guess the link intentionally pointed to the paragraph above, it was misleading depending on the current scroll position. When you enter the page via the search, it is already scrolled to #material-ui-pickers. The Link i edited is then in the center of the page (and therefore grabs visual attention). When clicked, it feels defunct, because nothing happens, because the page is already scrolled to the target position. The Link text represents a git repository name, so i would expect it to link to this repository. So i think the easiest solution is to actually do so.
|
No bundle size changes comparing 6dc8903...83bb14e |
joshwooding
approved these changes
Nov 25, 2019
mbrookes
approved these changes
Nov 25, 2019
This was referenced Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While i guess the link intentionally pointed to the paragraph above, it was misleading depending on the current scroll position.
When you enter the page via the search, it is already scrolled to #material-ui-pickers. The Link i edited is then in the center of the page (and therefore grabs visual attention). When clicked, it feels defunct, because nothing happens, because the page is already scrolled to the target position.
The Link text represents a git repository name, so i would expect it to link to this repository. So i think the easiest solution is to actually do so.