[TrapFocus] Guard against dropped memo cache #20848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 7d7e756...5d0c2a5 Details of page changes
|
joshwooding
reviewed
Apr 30, 2020
Co-Authored-By: Josh Wooding <[email protected]>
joshwooding
approved these changes
Apr 30, 2020
oliviertassinari
approved these changes
May 2, 2020
There was a problem hiding this comment.
I have tried to benchmark how a couple of alternatives handle the problem. I have found:
- Call during the constructor: https://github.com/davidtheclark/focus-trap-react/blob/e67d26c5ff512228007bd6eb55aea9841eb7e09d/src/focus-trap-react.js#L10
- Call during componentWillMount https://github.com/theKashey/react-focus-lock/blob/7a6c0c916a7f5c0a040bece84a8dea4e5f999b6d/src/Trap.js#L130
- Call during componentWillReceiveProps https://github.com/microsoft/fluentui/blob/4039ef722c1c3ee5bf14eed0a49477eaf773cd08/packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx#L40
- Call during the effect: https://github.com/zendeskgarden/react-containers/blob/be96fbd372bbde9d2cce30461b5027c78cbac221/packages/focusjail/src/useFocusJail.ts#L119.
Any idea how we could solve this?
What are you trying to solve? |
I was wondering about the concurrent mode issue you have raised and added as a comment. |
eps1lon
commented
May 2, 2020
Which is not an issue for the first 3 links. They obviously are meant to not work in concurrent mode. During a passive effect is too late for I think I made it clear that it's unclear whether this is actually an issue in concurrent mode considering how the committed effects relate to the |
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's still potentially unsafe for concurrent mode but at least it's now safe against useMemo dropping the cache because we create our own cache via
useRef.**Also adds a warning for a potential memory leak since
nodeToRestore.currentcould be unmounted while the modal is open. Though this is pretty unlikely to be an issue since you usually don't have many open modals.