Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Examples in the docs don't open on iPad #1309

Closed
michaldudak opened this issue Jan 8, 2025 · 2 comments · Fixed by #1342
Closed

[Menu] Examples in the docs don't open on iPad #1309

michaldudak opened this issue Jan 8, 2025 · 2 comments · Fixed by #1342
Assignees
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module!

Comments

@michaldudak
Copy link
Member

michaldudak commented Jan 8, 2025

The Menu demos in the Examples section don't open when clicked on an iPad. The main demo works fine and the examples are OK when opened in Codesandbox, but not straight from the docs.
Tested on a real device with iOS 18.0.1 and simulator on iOS 18.2.

Screen.Recording.2025-01-08.at.14.28.36.mov
@michaldudak michaldudak added component: menu This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Jan 8, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Base UI Jan 13, 2025
@colmtuite colmtuite moved this from Backlog to In progress in Base UI Jan 13, 2025
@mj12albert
Copy link
Member

Looks like a problem with useScrollLock, when clicking any of the non-main menu demo triggers, the scroll locks and unlocks immediately in this recording (at 16s and 33s). Adding onOpenChange will show that it's opening and immediately closing.

menu-scroll-lock.mp4

This is a real device on iPadOS 17.7.12, it's weird that it doesn't repro on a phone 🤔

@mj12albert
Copy link
Member

mj12albert commented Jan 16, 2025

Actually is it something to do with detectBrowser?
I think the 'data-base-ui-scroll-locked' attr shouldn't appear when using RA usePreventScroll when iOS is detected
@atomiks

Update: so apparently iPad navigator.platform returns 'MacIntel' now

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module!
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants