Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Touch interactions #954

Closed
vladmoroz opened this issue Dec 4, 2024 · 4 comments
Closed

[Popover] Touch interactions #954

vladmoroz opened this issue Dec 4, 2024 · 4 comments
Assignees
Labels
component: popover The React component. docs Improvements or additions to the documentation

Comments

@vladmoroz
Copy link
Contributor

vladmoroz commented Dec 4, 2024

  • Sometimes it's possible to open multiple popovers on a mobile device
  • Tapping a button to open one popover and then tapping quickly another one while the first one is still animating in won't open the last one like on desktop. Instead, the first one flickers and re-opens.
RPReplay_Final1733308078.mp4

Search keywords:

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 4, 2024
@vladmoroz vladmoroz added docs Improvements or additions to the documentation component: popover The React component. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 4, 2024
@atomiks
Copy link
Contributor

atomiks commented Dec 4, 2024

First dot point will be fixed with floating-ui/floating-ui#3130

@atomiks
Copy link
Contributor

atomiks commented Dec 5, 2024

Tapping a button to open one popover and then tapping quickly another one while the first one is still animating in won't open the last one like on desktop. Instead, the first one flickers and re-opens.

Haven't fully dug into this but wonder if it's related to small tap targets (<40px)? Seems like iOS decides to click the same button because it's too close perhaps? I'm not sure what would potentially cause the issue at the moment

@colmtuite colmtuite added this to Base UI Dec 9, 2024
@colmtuite colmtuite added this to the 1.0.0-alpha.1 release milestone Dec 9, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Base UI Dec 9, 2024
@vladmoroz
Copy link
Contributor Author

Haven't fully dug into this but wonder if it's related to small tap targets (<40px)? Seems like iOS decides to click the same button because it's too close perhaps? I'm not sure what would potentially cause the issue at the moment

Yeah I can't reproduce it when tapping targets that are further away from each other. Probably you are right, might be an iOS thing

@github-project-automation github-project-automation bot moved this from Backlog to Done in Base UI Dec 13, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: popover The React component. docs Improvements or additions to the documentation
Projects
Archived in project
Development

No branches or pull requests

3 participants