Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required TypeScript version #1282

Closed
eps1lon opened this issue Aug 26, 2019 · 1 comment
Closed

Required TypeScript version #1282

eps1lon opened this issue Aug 26, 2019 · 1 comment

Comments

@eps1lon
Copy link
Member

eps1lon commented Aug 26, 2019

With #1252 @material-ui/pickers requires Typescript 3.5 to get type checking. The linked PR assumes the Omit helper type from typescript which was only added in 3.5.

Environment

Tech Version
@material-ui/pickers 3.2.4
material-ui master
React 16.9.0
Browser
Peer library
Typescript 3.2.2

Steps to reproduce

mui/material-ui#17175

Expected behavior

Library works with TypeScript 3.x

Actual behavior

Requires 3.5

Live example

N/A

#1273 is likely caused by the same issue.
@eps1lon eps1lon mentioned this issue Aug 26, 2019
Closed
@Flash619
Copy link

Flash619 commented Sep 3, 2019 

type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>

Could you add the above to the type definitions for this project and simply use that in place until more users adopt TypeScript 3.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Flash619 @eps1lon