Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add built-in localization support #1429

Closed
2 tasks
dmtrKovalenko opened this issue Dec 20, 2019 · 4 comments · Fixed by #1773
Closed
2 tasks

Add built-in localization support #1429

dmtrKovalenko opened this issue Dec 20, 2019 · 4 comments · Fixed by #1773
Labels
enhancement New feature or request
Milestone
v5

Comments

@dmtrKovalenko
Copy link
Member

We should support new localization feature.

  • Rename props to look conventional to material ui text props :
    If we should rename the prop to titleText to something that starts to look like a convention:
  • backIconButtonText
  • labelRowsPerPage
  • labelDisplayedRows
  • nextIconButtonText
  • getLabelText
  • clearText
  • closeText
  • loadingText
  • noOptionsText
  • openText

Originally posted by @oliviertassinari in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzM1MDA1Njky/pull_request_reviews/more_threads

  • Make it possible to localize all formats from the localization feature. It should be a killer feature
@dmtrKovalenko
Copy link
Member Author

Requires new way to pass formats right to the pickers and new date-io version

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 20, 2019 •
edited
Loading

Yes! DatePicker and DataGrid are probably the two components that will benefit the most from an out of the box localization support.

@oliviertassinari oliviertassinari changed the title Material-ui localization support Add built-in localization support Jan 4, 2020
@oliviertassinari oliviertassinari added the enhancement New feature or request label Jan 4, 2020
@oliviertassinari oliviertassinari added this to the v4 milestone Apr 9, 2020
@dmtrKovalenko dmtrKovalenko mentioned this issue May 14, 2020
Merged
@oliviertassinari
Copy link
Member

Reopening until the counterpart change on https://github.com/mui-org/material-ui, if this is all right :).

@oliviertassinari oliviertassinari modified the milestones: v4, v5 Jul 13, 2020
@oliviertassinari oliviertassinari mentioned this issue Oct 8, 2020
Closed
@oliviertassinari
Copy link
Member

Closing for mui/material-ui#23674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v5
Development

Successfully merging a pull request may close this issue.

Implement text props name convention mui/material-ui-pickers
2 participants
@oliviertassinari @dmtrKovalenko