Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor formatting problem when moment locale is zh-cn #153

Closed
cthurston opened this issue Jan 1, 2018 · 7 comments
Closed

Minor formatting problem when moment locale is zh-cn #153

cthurston opened this issue Jan 1, 2018 · 7 comments

Comments

@cthurston
Copy link

Steps to reproduce

  1. Set the moment.locale('zh-cn')
  2. Open DateTimePicker

Expected behavior

Date to be in a single line.

Actual behavior

Date takes two lines.

screen shot 2017-12-31 at 6 41 05 pm

@cherniavskii
Copy link
Member

Hi Christopher,
Please do not ignore our issue template - in your case Environment section is missing.

I can't reproduce your issue - here's the result:
(link to playground: https://codesandbox.io/s/m3zo490r4p)
selection_014

That being said, I think it would be better to change toolbar styles from justify-content: center to justify-content: space-around:
selection_015

@cthurston
Copy link
Author

Environment

MacBook Pro OS High Sierra
Chrome Version 63.0.3239.84 (Official Build) (64-bit)
Tried Safari and it had the issue as well.

It is reproducible on the codesandbox link that you provided in my environment.

screen shot 2018-01-01 at 12 56 49 pm

@dmtrKovalenko
Copy link
Member

I have no idea how to fix the issue that is not reproducible for us even on the sandbox, only one thing, that can be a problem - default fontsize of system?
So closing this issue.

@cthurston
Copy link
Author

Still occurs on my system.

If the H1 font size that contains the date is 2.125em it bumps down. If the font size is 2.110em is does not bump down.

Also, if the font size is the same, but the margin-left on the H1 is -0.06em instead of -0.04em is does not bump down.

So it's definitely close.

@cherniavskii
Copy link
Member

huh, I actually can reproduce it now on 4k screen, so it's related to devicePixelRation I guess.

@cherniavskii
Copy link
Member

cherniavskii commented Feb 23, 2018

@cthurston I've submitted a PR, could you check if it fixes your issue?

@cthurston
Copy link
Author

That fixed it. Thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants