Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing renderInput prop-type #1750

Closed
IgorTurko opened this issue May 7, 2020 · 9 comments · Fixed by #1761
Closed

Missing renderInput prop-type #1750

IgorTurko opened this issue May 7, 2020 · 9 comments · Fixed by #1761
Labels

Comments

@IgorTurko
Copy link

IgorTurko commented May 7, 2020

Environment

Tech Version
@material-ui/pickers 4.0.0-alpha.6
material-ui 4.9.13
React 16.12
Browser Chrome
Peer library moment-io

I have this DatePicker with latest alpha6

          <DatePicker
            variant="outlined"
            autoOk
            //renderInput={TextField}
            value={date}
            disabled={isLoading}
            onChange={newDate => onChange(newDate.format(apiDateFormat))}
            maxDate={maxDate}
            disablePast
          />

When I comment out the renderInput props I get error "renderInput is not a function";
image

Am I doing something wrong? Or renderInput required now?

@dmtrKovalenko
Copy link
Member

You must provide renderInput Prop. Which is required from v4-alpha.6

@IgorTurko
Copy link
Author

@dmtrKovalenko do we have this as an example somewhere?

@dmtrKovalenko
Copy link
Member

Everywhere in the docs for v4.alpha. Check https://next.material-ui-pickers.dev

@oliviertassinari
Copy link
Member

oliviertassinari commented May 7, 2020

Am I doing something wrong? Or renderInput required now?

@dmtrKovalenko Don't we miss a prop-type warning? Compare the error "recovery" experience between

@oliviertassinari oliviertassinari changed the title DatePicker throw error renderInput is not a function DatePicker missing renderInput prop-type May 8, 2020
@oliviertassinari oliviertassinari changed the title DatePicker missing renderInput prop-type Missing renderInput prop-type May 8, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented May 8, 2020

I have repurposed a bit the issue to focus on the missing prop-type.

Am I doing something wrong? Or renderInput required now?

I imagine that it's not the only prop type missing. I guess we should wait for the migration in the mono-repository to benefit from this constraint: "CI fail if there is a missing prop-type".

@CodingDive

This comment has been minimized.

@oliviertassinari

This comment has been minimized.

@danielstern
Copy link

Still getting this error

@LukasTy
Copy link
Member

LukasTy commented Feb 23, 2023

This library is no longer maintained @danielstern.
Consider upgrading to @mui/x-date-pickers by following this guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants