Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRangePicker issues in a Popover #1947

Closed
2 tasks done
ggascoigne opened this issue Jul 1, 2020 · 1 comment
Closed
2 tasks done

DateRangePicker issues in a Popover #1947

ggascoigne opened this issue Jul 1, 2020 · 1 comment
Labels
component: DateRangePicker duplicate This issue or pull request already exists

Comments

@ggascoigne
Copy link

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

We've been trying to use the DateRangePicker in a Popover and have issues with the control closing prematurely.

Pretty much any click in the control causes it to close, this means that you can't navigate months, and if you click on a start date the control closes and you have to reopen it to select the end date.

Based on some other issues we tried displaying the form in a Popper, for the DateRangePicker that did work, but it makes Select controls unusable. Any click on them causes the containing Popper to close.

This is a desktop and not a mobile use case.

Expected Behavior 🤔

Some popup like behavior should work with both Select and DateRangePicker at the same time.

Steps to Reproduce 🕹

Here's a simple example that shows both behaviors: https://codesandbox.io/s/github/ggascoigne/date-picker-bug

The Popover has a Select that works and a DateRangePicker that doesn't, the Popper has a working DateRangePicker and a broken Select.

Context 🔦

We have a popup that displays a number of filtering fields that are then applied to a table. The popup is pretty transient, with filters applied onBlur and on return.

Your Environment 🌎

Tech Version
@material-ui/core v4.11.0
@material-ui/pickers v4.0.0-alpha.8

Note that I tried this same example with a local build of the latest 6a09d98 version and it appears to have the same behavior, which is a bit odd, I'd have expected that #1850 might have effected this.

@ggascoigne ggascoigne added the status: needs triage These issues haven't been looked at yet by a maintainer. label Jul 1, 2020
@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists component: DateRangePicker and removed status: needs triage These issues haven't been looked at yet by a maintainer. labels Jul 2, 2020
@oliviertassinari
Copy link
Member

Duplicate of #1852

@oliviertassinari oliviertassinari marked this as a duplicate of #1852 Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DateRangePicker duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants