Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in the docs #2046

Closed
aamirafridi opened this issue Jul 29, 2020 · 8 comments · Fixed by #2048
Closed

Broken link in the docs #2046

aamirafridi opened this issue Jul 29, 2020 · 8 comments · Fixed by #2048
Labels
bug 🐛 Something isn't working docs good first issue Great for newcomers

Comments

@aamirafridi
Copy link
Contributor

https://v4-0-0-alpha-10.material-ui-pickers.dev/api/DateRangePicker

The link provided for the prop dateAdapter is broken

broken link for here

Allows to pass configured date-io adapter directly. More info here

@aamirafridi aamirafridi added the status: needs triage These issues haven't been looked at yet by a maintainer. label Jul 29, 2020
@dmtrKovalenko
Copy link
Member

@dmtrKovalenko dmtrKovalenko added bug 🐛 Something isn't working docs good first issue Great for newcomers and removed status: needs triage These issues haven't been looked at yet by a maintainer. labels Jul 29, 2020
@dmtrKovalenko
Copy link
Member

If you would like to open PR and fix the issue - it would be awesome :)

@aamirafridi
Copy link
Contributor Author

@dmtrKovalenko should I replace the absolute links to relative paths in docs/prop-types.json ?

e.g. replace:

"description": "Allows to pass configured date-io adapter directly. More info [here](https://material-ui-pickers.dev/guides/date-adapter-passing)\n```jsx\ndateAdapter={new DateFnsAdapter({ locale: ruLocale })}\n```",

with

"description": "Allows to pass configured date-io adapter directly. More info [here](/guides/date-adapter-passing)\n```jsx\ndateAdapter={new DateFnsAdapter({ locale: ruLocale })}\n```",

@dmtrKovalenko
Copy link
Member

Ha ha ha. It is more deep problem. Originally it was required to set the right link in the inteliisince right in editor.

For now only add 'next.' prefix

@aamirafridi
Copy link
Contributor Author

#2048

@aamirafridi
Copy link
Contributor Author

The propose file link is broken too here

image

@oliviertassinari
Copy link
Member

@aamirafridi No need to worry about it, we are working on moving the component to the main repository infrastructure, so we don't have to fix bugs like this one twice (we have that type of regression a couple of time on main).

@aamirafridi
Copy link
Contributor Author

ok cool. thanks :)
I think this issue still needs to resolved and reopened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working docs good first issue Great for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants