From 043bb210c12091ce3373addb84e3dea52216bc33 Mon Sep 17 00:00:00 2001 From: sai chand <60743144+sai6855@users.noreply.github.com> Date: Mon, 8 Jul 2024 14:40:24 +0530 Subject: [PATCH] [mui-lab] Fix issues reported by react-compiler in mui-lab (#42880) --- packages/mui-lab/src/Alert/Alert.js | 12 ++++++++---- packages/mui-lab/src/AlertTitle/AlertTitle.js | 12 ++++++++---- packages/mui-lab/src/Autocomplete/Autocomplete.js | 12 ++++++++---- packages/mui-lab/src/AvatarGroup/AvatarGroup.js | 12 ++++++++---- packages/mui-lab/src/Pagination/Pagination.js | 12 ++++++++---- .../mui-lab/src/PaginationItem/PaginationItem.js | 12 ++++++++---- packages/mui-lab/src/Rating/Rating.js | 12 ++++++++---- packages/mui-lab/src/Skeleton/Skeleton.js | 12 ++++++++---- packages/mui-lab/src/SpeedDial/SpeedDial.js | 12 ++++++++---- .../mui-lab/src/SpeedDialAction/SpeedDialAction.js | 12 ++++++++---- packages/mui-lab/src/SpeedDialIcon/SpeedDialIcon.js | 12 ++++++++---- packages/mui-lab/src/TabContext/TabContext.test.js | 1 + packages/mui-lab/src/ToggleButton/ToggleButton.js | 12 ++++++++---- .../src/ToggleButtonGroup/ToggleButtonGroup.js | 12 ++++++++---- 14 files changed, 105 insertions(+), 52 deletions(-) diff --git a/packages/mui-lab/src/Alert/Alert.js b/packages/mui-lab/src/Alert/Alert.js index e668364a8b65e4..d2b7e1446b61d3 100644 --- a/packages/mui-lab/src/Alert/Alert.js +++ b/packages/mui-lab/src/Alert/Alert.js @@ -4,10 +4,7 @@ import Alert from '@mui/material/Alert'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedAlert(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedAlert(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedAlert(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/AlertTitle/AlertTitle.js b/packages/mui-lab/src/AlertTitle/AlertTitle.js index 7a38fb93de2922..58b2b67b4f3519 100644 --- a/packages/mui-lab/src/AlertTitle/AlertTitle.js +++ b/packages/mui-lab/src/AlertTitle/AlertTitle.js @@ -4,10 +4,7 @@ import AlertTitle from '@mui/material/AlertTitle'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedAlertTitle(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedAlertTitle(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedAlertTitle(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/Autocomplete/Autocomplete.js b/packages/mui-lab/src/Autocomplete/Autocomplete.js index 5556dd314c5c6f..736534740da687 100644 --- a/packages/mui-lab/src/Autocomplete/Autocomplete.js +++ b/packages/mui-lab/src/Autocomplete/Autocomplete.js @@ -4,10 +4,7 @@ import Autocomplete from '@mui/material/Autocomplete'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedAutocomplete(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedAutocomplete(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedAutocomplete(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/AvatarGroup/AvatarGroup.js b/packages/mui-lab/src/AvatarGroup/AvatarGroup.js index 2b8805621c0671..c3654d49687308 100644 --- a/packages/mui-lab/src/AvatarGroup/AvatarGroup.js +++ b/packages/mui-lab/src/AvatarGroup/AvatarGroup.js @@ -4,10 +4,7 @@ import AvatarGroup from '@mui/material/AvatarGroup'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedAvatarGroup(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedAvatarGroup(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedAvatarGroup(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/Pagination/Pagination.js b/packages/mui-lab/src/Pagination/Pagination.js index 35cd7d141f0887..eff2c35cb1bcde 100644 --- a/packages/mui-lab/src/Pagination/Pagination.js +++ b/packages/mui-lab/src/Pagination/Pagination.js @@ -4,10 +4,7 @@ import Pagination from '@mui/material/Pagination'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedPagination(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedPagination(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedPagination(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/PaginationItem/PaginationItem.js b/packages/mui-lab/src/PaginationItem/PaginationItem.js index 6a820a2fe69eb1..e3aa8989fb795c 100644 --- a/packages/mui-lab/src/PaginationItem/PaginationItem.js +++ b/packages/mui-lab/src/PaginationItem/PaginationItem.js @@ -4,10 +4,7 @@ import PaginationItem from '@mui/material/PaginationItem'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedPaginationItem(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedPaginationItem(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedPaginationItem(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/Rating/Rating.js b/packages/mui-lab/src/Rating/Rating.js index 8650246d46cc43..1378a504862090 100644 --- a/packages/mui-lab/src/Rating/Rating.js +++ b/packages/mui-lab/src/Rating/Rating.js @@ -4,10 +4,7 @@ import Rating from '@mui/material/Rating'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedRating(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedRating(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedRating(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/Skeleton/Skeleton.js b/packages/mui-lab/src/Skeleton/Skeleton.js index 8062cb2ccf1a09..d929a8a73ebd72 100644 --- a/packages/mui-lab/src/Skeleton/Skeleton.js +++ b/packages/mui-lab/src/Skeleton/Skeleton.js @@ -4,10 +4,7 @@ import Skeleton from '@mui/material/Skeleton'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedSkeleton(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedSkeleton(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedSkeleton(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/SpeedDial/SpeedDial.js b/packages/mui-lab/src/SpeedDial/SpeedDial.js index 7904327ac2cdaa..932ffe4d6201f9 100644 --- a/packages/mui-lab/src/SpeedDial/SpeedDial.js +++ b/packages/mui-lab/src/SpeedDial/SpeedDial.js @@ -4,10 +4,7 @@ import SpeedDial from '@mui/material/SpeedDial'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedSpeedDial(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedSpeedDial(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedSpeedDial(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/SpeedDialAction/SpeedDialAction.js b/packages/mui-lab/src/SpeedDialAction/SpeedDialAction.js index f4ee276ff2f5e7..19f1db1eedfa12 100644 --- a/packages/mui-lab/src/SpeedDialAction/SpeedDialAction.js +++ b/packages/mui-lab/src/SpeedDialAction/SpeedDialAction.js @@ -4,10 +4,7 @@ import SpeedDialAction from '@mui/material/SpeedDialAction'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedSpeedDialAction(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedSpeedDialAction(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedSpeedDialAction(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/SpeedDialIcon/SpeedDialIcon.js b/packages/mui-lab/src/SpeedDialIcon/SpeedDialIcon.js index 9ad37129261529..8a8b7b98b2d43d 100644 --- a/packages/mui-lab/src/SpeedDialIcon/SpeedDialIcon.js +++ b/packages/mui-lab/src/SpeedDialIcon/SpeedDialIcon.js @@ -4,10 +4,7 @@ import SpeedDialIcon from '@mui/material/SpeedDialIcon'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedSpeedDialIcon(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedSpeedDialIcon(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedSpeedDialIcon(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/TabContext/TabContext.test.js b/packages/mui-lab/src/TabContext/TabContext.test.js index e2871b415bc24f..664124493a6c70 100644 --- a/packages/mui-lab/src/TabContext/TabContext.test.js +++ b/packages/mui-lab/src/TabContext/TabContext.test.js @@ -11,6 +11,7 @@ describe('', () => { it('is null by default', () => { let value; function Tabs() { + // TODO: uncomment once we enable eslint-plugin-react-compiler // eslint-disable-next-line react-compiler/react-compiler -- value is used outside of component value = useTabContext(); return null; } diff --git a/packages/mui-lab/src/ToggleButton/ToggleButton.js b/packages/mui-lab/src/ToggleButton/ToggleButton.js index cfd1a8feb1d044..9e59c52a9fab96 100644 --- a/packages/mui-lab/src/ToggleButton/ToggleButton.js +++ b/packages/mui-lab/src/ToggleButton/ToggleButton.js @@ -4,10 +4,7 @@ import ToggleButton from '@mui/material/ToggleButton'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedToggleButton(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedToggleButton(props, ref) { warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedToggleButton(props, ref) { + warn(); return ; }); diff --git a/packages/mui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js b/packages/mui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js index 5f1bb01afed3b3..c1b6f986ea0016 100644 --- a/packages/mui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js +++ b/packages/mui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js @@ -4,10 +4,7 @@ import ToggleButtonGroup from '@mui/material/ToggleButtonGroup'; let warnedOnce = false; -/** - * @ignore - do not document. - */ -export default React.forwardRef(function DeprecatedToggleButtonGroup(props, ref) { +const warn = () => { if (!warnedOnce) { console.warn( [ @@ -20,6 +17,13 @@ export default React.forwardRef(function DeprecatedToggleButtonGroup(props, ref) warnedOnce = true; } +}; + +/** + * @ignore - do not document. + */ +export default React.forwardRef(function DeprecatedToggleButtonGroup(props, ref) { + warn(); return ; });