From 32b72af743ea167b23d31824da591f9257a39927 Mon Sep 17 00:00:00 2001 From: Ryan Cogswell <287804+ryancogswell@users.noreply.github.com> Date: Fri, 22 Apr 2022 22:46:12 -0500 Subject: [PATCH] [codemod] Leave numeric arguments to breakpoints functions unchanged - The codemod was previously changing numeric values to `undefined` --- packages/mui-codemod/src/v5.0.0/theme-breakpoints.js | 10 ++++++++-- .../src/v5.0.0/theme-breakpoints.test/actual.js | 1 + .../src/v5.0.0/theme-breakpoints.test/expected.js | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/mui-codemod/src/v5.0.0/theme-breakpoints.js b/packages/mui-codemod/src/v5.0.0/theme-breakpoints.js index 335448c92905ba..271b3969012e7c 100644 --- a/packages/mui-codemod/src/v5.0.0/theme-breakpoints.js +++ b/packages/mui-codemod/src/v5.0.0/theme-breakpoints.js @@ -22,7 +22,10 @@ export default function transformer(file, api, options) { }) .forEach((path) => { path.node.arguments.forEach((node) => { - node.value = map[node.value]; + const replacementValue = map[node.value]; + if (replacementValue !== undefined) { + node.value = replacementValue; + } }); }); @@ -36,7 +39,10 @@ export default function transformer(file, api, options) { }) .forEach((path) => { const node = path.node.arguments[1]; - node.value = map[node.value]; + const replacementValue = map[node.value]; + if (replacementValue !== undefined) { + node.value = replacementValue; + } }); return root.toSource(printOptions); diff --git a/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/actual.js b/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/actual.js index cf557112788e54..7fbce7805170eb 100644 --- a/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/actual.js +++ b/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/actual.js @@ -1,4 +1,5 @@ theme.breakpoints.down('sm') theme.breakpoints.down('xl') +theme.breakpoints.down(360) theme.breakpoints.between('sm', 'md') theme.breakpoints.between('sm', 'xl') diff --git a/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/expected.js b/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/expected.js index 781ab00583dd2e..edd8256725eeb0 100644 --- a/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/expected.js +++ b/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/expected.js @@ -1,4 +1,5 @@ theme.breakpoints.down('md') theme.breakpoints.down('xl') +theme.breakpoints.down(360) theme.breakpoints.between('sm', 'lg') theme.breakpoints.between('sm', 'xl')