Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATEPICKER] Safari autofill for birthday causes infinite rerenders and crashes browser #11063

Closed
hughkolias opened this issue Apr 18, 2018 · 2 comments
Labels
component: date picker This is the name of the generic UI component, not the React module! v0.x

Comments

@hughkolias
Copy link

hughkolias commented Apr 18, 2018

General Summary

When using datepicker, the safari browser tries to autofill the birthday into the field in an infinite loop, causing the browser to crash.

Changing the name and textfield fixes the issue, as does removing autofill from the browser.

We've tried autoComplete='off' in as well as in the component, as well as autoComplete='None'.

Is there a way to disable autofill to prevent this from happening? Has anyone else seen this issue?

This is not an issue in other browsers.

  • [x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Should not allow autofill in the DatePicker. Autofill should not break datepicker.

Current Behavior

See general summary above.

Steps to Reproduce (for bugs)

  1. Create a form with the material-ui datepicker with name = birthday and hintText = birthday
  2. Save the form
  3. Make sure you have birthday as an autofill option in safari
  4. Click on birthday again, app should break

Your Environment

Tech Version
Material-UI 0.19.2
React 15.5.4
browser SAFARI 11.0.3
@oliviertassinari oliviertassinari added v0.x component: date picker This is the name of the generic UI component, not the React module! labels Apr 18, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 19, 2018

@hughkolias The date picker is a challenging component to implement. The complexity comes from different sources: date manipulation and correctness, internationalization, keyboard/touch/mouse interactions, customization capabilities. We haven't been porting it to the v1-beta branch yet, nor it's a priority. But we are documenting alternatives. Here are some components that are promising:

I'm closing for #4787.

We encourage people starting with Material-UI to go with v1-beta. The master branch is in a low maintenance mode. We don't plan any work on it. However, we still do our best to review and merge pull requests that fix bugs on this branch.

@hughkolias
Copy link
Author

Thanks so much for the response, and the awesome library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: date picker This is the name of the generic UI component, not the React module! v0.x
Projects
None yet
Development

No branches or pull requests

2 participants