Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] Chip should be styled clickable when component is a #11502

Closed
2 tasks done
ThewBear opened this issue May 20, 2018 · 3 comments
Closed
2 tasks done

[Chip] Chip should be styled clickable when component is a #11502

ThewBear opened this issue May 20, 2018 · 3 comments
Labels
component: chip This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@ThewBear
Copy link
Contributor

ThewBear commented May 20, 2018 •
edited
Loading

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

When the component of the chip is a, the chip should be styled like there is onClick prop.

Current Behavior

Chip is styled as basic chip and label text is underlined.
@mbrookes mbrookes added component: chip This is the name of the generic UI component, not the React module! new feature New feature or request labels May 20, 2018
@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label May 26, 2018
@oliviertassinari
Copy link
Member

@thebear44 The expected behavior sounds correct, but I don't think that we can have an implementation as straightforward. What about adding a clickable or button property to enable such behavior?

@vilvaathibanpb
Copy link
Contributor

@oliviertassinari I agree as that will be a better way. I have created a PR for the same. Please review and provide your comments:

#11613

@vilvaathibanpb
Copy link
Contributor

someone, please help me with my PR. this is my first Open source contribution and I am facing issues which I am not able to figure out in my PR

@vilvaathibanpb vilvaathibanpb mentioned this issue May 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: chip This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mbrookes @oliviertassinari @vilvaathibanpb @ThewBear